[Windmill-dev] https; file uploads; extjs and click support

[Adam Christian]

Matthew,

Thanks for the feedback, I have to admit when I first started tackling  
this issue this morning I did add the option field for click allowing  
another param to be passed to decide whether to preventDefault or  
not.. I actually ripped it out because looking at the test in the IDE  
now all the clicks have another option available and a large percent  
of the time this option wasn't used... and it didn't look as nice. In  
retrospect I guess that is a relatively silly reason, but I created  
the clickAjax method to solve it..

Looking back at this it appears that the whole set of click logic  
might need to be improved. Currently I look to see if the element has  
a href and that it doesn't contain 'javascript:' then I check the  
parent to see if that has the same, if not I call the open on the  
url.. this way we can use the logic in the open to calculate when the  
unloads, onloads and reattaching of events happen on the next page.  
Currently the clickAjax just sets a flag to not do any href following.

Looking at this now, maybe I need to follow the parentNode chain all  
the way up to check for a href to accommodate elements multiple levels  
inside of a link node.

What do people think? New methods that prevent default, or adding a  
param to existing methods? I really am open to both as the difference  
is basically aesthetic.

Adam

On Dec 16, 2007, at 11:06 PM, Matthew Eernisse wrote:

> Adam,
>
> It might be worth considering allowing a preventDefault option to be  
> passed which would call that method immediately on our events before  
> they are actually dispatched, if it will work. It might not be that  
> hard to do, and would keep us from having to add new method calls to  
> the API.
>
> (With a wee bit of thought I realized how silly a stopPropagation  
> option would be -- you'd have an event that does absolutely nothing,  
> duh. :))
>
> On the other hand, if you're going to keep the current new method,  
> could you consider naming it something more descriptive? I can think  
> of two specific cases where the preventDefault option comes into  
> play a lot -- following links on a click, and the default submission  
> of forms with the onsubmit.
>
> Perhaps all we need is something like clickNoFollowLink, and  
> submitNoSubmitActualForm or something.
>
> On the other hand, being able to call preventDefault preemptively on  
> all our actions might be more flexible.
>
>
> Matthew
>
>
> Adam Christian wrote:
>> Gary,
>> Again in this case, for the time being I am going to blame the  
>> JavaScript framework for stopping propagation in a way that makes  
>> recording these actions nearly impossible.
>> However, I fixed a bug in the click function keeping it from firing  
>> the mousedown correctly which stopped it from playing back.
>> So the solution for now is to click 'Add Action' and set the  
>> locator using the DOM explorer. As I said earlier, if you want the  
>> action to work in the future I would set the 'Use XPath only for  
>> explorer/recorder' when exploring this action, because those ID's  
>> change constantly.
>> The fix is checked into the trunk and will be released in 0.3.6  
>> within the next few days.
>> Sorry we couldn't make this work OOTB, but I will keep my eye out  
>> for a slicker fix for this rather large issue.
>> Adam
>> On Dec 16, 2007, at 9:10 AM, Gary Poster wrote:
>>> Hi.  I talked with Mikael on IRC yesterday: thank you again!
>>>
>>> I mentioned to him that we needed https for our app, and he said  
>>> that it was hard, but in progress.  That's great to hear.
>>>
>>> In exploring Windmill some more today I encountered a couple of  
>>> other problems.
>>>
>>> The first is that I don't see a work-around for file uploads.  For  
>>> what it's worth, Sahi, which appears to have a similar basic  
>>> approach to Windmill's, does this for the problem: http://sahi.sourceforge.net/apis.html#setFile 
>>>  .
>>>
>>> Any chance you all might have a solution for file uploads coming  
>>> soon?
>>>
>>> The second is that Windmill is missing quite a few important  
>>> clicks in extjs.  For instance, try recording on this page:  
>>> ``windmill firefox http://extjs.com/deploy/dev/examples/grid/edit-grid.html 
>>> `` .  If you click the checkboxes on the right, nothing happens in  
>>> the recorder; and if you use the calendar widgets, it won't see  
>>> the click on a number.  The checkboxes are not real checkboxes,  
>>> but I have the "Absolute click sensitivity when recording:" option  
>>> turned on.  I don't know about selenium or sahi on this page.
>>>
>>> Is this a bug that you all are willing to address?
>>>
>>> Thanks
>>>
>>> Gary
>>> _______________________________________________
>>> Windmill-dev mailing list
>>> Windmill-dev at osafoundation.org
>>> http://lists.osafoundation.org/mailman/listinfo/windmill-dev
>> _______________________________________________
>> Windmill-dev mailing list
>> Windmill-dev at osafoundation.org
>> http://lists.osafoundation.org/mailman/listinfo/windmill-dev
>
> _______________________________________________
> Windmill-dev mailing list
> Windmill-dev at osafoundation.org
> http://lists.osafoundation.org/mailman/listinfo/windmill-dev