[pyicu-dev] [PATCH] Add correct namespace declarations everywhere

[Andi Vajda]

On Tue, 11 Sep 2007, Fredrik Roubert wrote:

> On 9/11/07, Andi Vajda <vajda at osafoundation.org> wrote:
>
>> Probably because of my very spotty knowledge of C++ at the time.
>> If you submit another patch removing all occurrences of icu::, I'll take it
>> too.
>
> OK, here's such a patch. It removes all occurrences of icu:: and uses
> U_NAMESPACE_USE in common.h, as proposed by Steven, instead.

One glitch in your patch: in common.h, the UStringEnumeration definition still 
needs to be wrapped with U_NAMESPACE_BEGIN and U_NAMESPACE_END. Without it, 
PyICU doesn't link. I'm building against ICU 3.6.

Other than that, all seems fine.
Thank you !

Andi..