[pyicu-dev] [PATCH] Add correct namespace declarations everywhere

Andi Vajda vajda at osafoundation.org
Tue Sep 11 13:03:48 PDT 2007


On Tue, 11 Sep 2007, Fredrik Roubert wrote:

>> By the way, I think it is harmless to include namespaces multiple times. So
>> a simpler version of my previous patch would just be to put
>> 'U_NAMESPACE_USE' somewhere after the icu #includes .  Then it should just
>> always work.  and the icu:: should not be needed
>
> I really don't know why it was decided to use icu:: in PyICU in the
> first place, and it might certainly be a good idea to change that.

Probably because of my very spotty knowledge of C++ at the time.
If you submit another patch removing all occurrences of icu::, I'll take it 
too.

Andi..


More information about the pyicu-dev mailing list