[pyicu-dev] [PATCH] Add correct namespace declarations everywhere

Steven R. Loomis srl at icu-project.org
Tue Sep 11 12:02:23 PDT 2007


Your patch will break if the renaming preferences are changed by the  
user. They may be constrained by their own codebase :)

It's better to just make pyicu follow the current settings given in  
the #include files - that's what they are there for.

By the way, I think it is harmless to include namespaces multiple  
times. So a simpler version of my previous patch would just be to put  
'U_NAMESPACE_USE' somewhere after the icu #includes .  Then it should  
just always work.  and the icu:: should not be needed

-s

On 11 Set 2007, at 11:55, Fredrik Roubert wrote:

> On 9/11/07, Andi Vajda <vajda at osafoundation.org> wrote:
>
>> I'm tempted to revert your namespace patch :) ?
>
> I can certainly have made errors in the analysis of my problem and in
> the proposed solution, but the problem is real enough and the patch
> does solve it, so it would be nice of you to keep the patch until a
> better solution is eventually proposed. I can't see how the patch does
> any harm.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osafoundation.org/pipermail/pyicu-dev/attachments/20070911/780b057d/attachment.html


More information about the pyicu-dev mailing list