[pyicu-dev] [PATCH] Add correct namespace declarations everywhere

[Fredrik Roubert]

On 9/11/07, Steven R. Loomis <srl at icu-project.org> wrote:

> Why are you compiling with -DU_USING_ICU_NAMESPACE=0?

It's not my decision, it's the way it is in the codebase I'm working in.

> You can build ICU with that same option and then it will be consistent.

I don't follow you. Setting U_USING_ICU_NAMESPACE=0 while building ICU
won't change the ICU header files in any way, will it?

> in any event your patch should probably use the U_NAMESPACE_QUALIFIER
> instead of the static string icu::

That might certainly be a good idea, but I choose to just use icu:: as
that was the way it was already done in PyICU (there are 762
occurrences of icu:: in SVN revision 78).

> So, i think the patch should not be needed.

But how do you then propose that I build PyICU with U_USING_ICU_NAMESPACE=0?

-- 
Fredrik Roubert
roubert at google.com