[Dev] commit diffs

[Reid Ellis]

Indentation is indeed important, but if the indenting is changed, the  
code must also change as well. Right now it's almost impossible to  
look at a 300-line diff and say simply 'Oh, he put the whole thing  
inside an "if" statement'.

I would argue that the email (which is for informitive purposes  
anyway) would be far more useful if we just say the "if" line a  
perhaps 5 lines of context.

Reid

On Mon Jan 9 2006, at 19:45, Mike Taylor wrote:
> Grant raises a point I was thinking about but didn't mention...
>
> If I do determine I can enable that option then I will need to know  
> what repository you want to use it  on - as Grant points out it  
> will only be useful for repositories where python (or patch files)  
> are not the norm.
>
>
> On Jan 9, 2006, at 7:33 PM, Grant Baillie wrote:
>
>>
>> On Jan 9, 2006, at 16:23, Reid Ellis wrote:
>>
>>> I don't supposed there's any chance to get diffs to ignore  
>>> leading whitespace (diff -bw would be good) so that the actual  
>>> changes are easier to see?
>>
>> Hmmm, but leading whitespace has meaning in Python, no? I'm not  
>> sure that would be such a good idea for most of the diffs we  
>> generate.
>>
>> (It's definitely not a good idea for patches, of course).
>>
>> --Grant
> Bear