[Dev] removing $Revision $ lines

Grant Baillie grant at osafoundation.org
Mon Oct 31 11:27:52 PST 2005


+1

(although not as enthusiastically as some others; in my various  
editor configurations, it's not an issue, also see inline comments  
below).

On Oct 28, 2005, at 17:18, Ted Leung wrote:

> I think that in the CVS era, the $Revision lines were useful since  
> files had their own revision numbers.   Since we are using  
> subversion and all files have the same revision number, the  
> $Revision tag seems less useful,

To clarify a potential misconception here:

The $Revision tag tells you the last checked-in revision of the given  
file, not the current revision of (all the files in) the project.

> since it's much easier to determine which version of a file someone  
> has out in the field.

For svn checked-out projects, as you say, having it be present in  
individual files is mostly redundant with the cvs -> svn change. You  
can find it out, without having to talk to the server, via the "svn  
info" command (*).

The one case I can see for keeping it is that it's a little extra bit  
of book-keeping information for end-user (i.e. non-svn checked out)  
copies of Chandler. Having seen some unintended end-user merges of  
trees of files in the past, I'm a little hesitant to remove this  
information. (Admittedly, it can be recovered, but that can be pretty  
painstaking).

--Grant

(*) As an aside, not needing a server connection for the common cases  
of "svn info" and "svn diff" alone is worth upgrading to svn.


> If we were back in the CVS days, I'd prefer to keep them.   One  
> more reason to be glad we left that behind.
>
> +1
>
> Ted
>
> On Oct 28, 2005, at 4:57 PM, Heikki Toivonen wrote:
>
>
>> Alec Flett wrote:
>>
>>
>>> So at the top of many of our source files, we have a line like:
>>> @version:   $Revision: 8121 $
>>> (or sometimes we use __version__ =...)
>>>
>>> This drives me NUTS because every time I check in a file, I have  
>>> to then
>>> reload the file into my editor because it changes on disk as a  
>>> result of
>>> the checkin. I can't imagine I'm the only one with this issue.
>>>
>>> Is anyone emotionally tied to the $Revision$ lines?  Would anyone  
>>> mind
>>> if I nuked them?
>>>
>>>
>>
>> +1
>>
>> I have mostly worked around this issue by changing my editor  
>> settings to
>> reload files automatically, but that is not ideal either as I  
>> sometimes
>> don't want that to happen.
>>
>> All of the auto updated things cause havoc with diffs and merges  
>> every
>> now and then (SVN is better than CVS most of the time).
>>
>> We currently seem to be using __version__ in at least the file
>> application/Utility.py (don't know of other places).
>>
>> -- 
>>   Heikki Toivonen
>>
>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>
>> Open Source Applications Foundation "Dev" mailing list
>> http://lists.osafoundation.org/mailman/listinfo/dev
>>
>>
>
> ----
> Ted Leung                 Open Source Applications Foundation (OSAF)
> PGP Fingerprint: 1003 7870 251F FA71 A59A  CEE3 BEBA 2B87 F5FC 4B42
>
>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "Dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/dev
>



More information about the Dev mailing list