[Dev] review stalemate - what to do next?

[John Anderson]

I've lived in worlds 1, 2 and 3, and in my experience 1 has worked best.

The guy whose working on the code needs to feel that he has ownership, 
which is important for his motivation. In the long run good and bad 
ideas often sort themselves out through use and time, so even if the 
owner chooses the wrong choice, he'll often change his mind if 
experience bears out a bad decision, which turn out to be an important 
learning experience.

I've almost never seen the owner abuse the privilege of overruling a 
reviews opinion, that actually hurt the project.

John

Mike Taylor wrote:

> Earlier today Heikki and I reached the point where we could not find 
> common ground on the result of a review I requested from him about 
> some changes to the Makefiles.  I think that one of the review points 
> he raised is not a concern (a "style" issue to be exact) where as he 
> thinks the code is wrong because of duplication.
>
> The exact code involved is not the question I'm raising right now, but 
> rather this is something we haven't considered in our review process - 
> what happens when the owner of the patch/code and the reviewer of the 
> patch/code just cannot agree?
>
> After talking about this with Heikki, he asked that I submit it as a 
> discussion and vote to the dev list.
>
> If the reviewer and the owner disagree, which of the following apply:
>
>     1. Owner's opinion prevails
>     2. Reviewer's opinion prevails
>     3. It's put to a vote before an impartial body - most of the time 
> that body will be the dev list
>     4. <insert alternative solution here>
>
> thanks,
>
> ---
> Bear
>
> Build and Release Engineer
> Open Source Applications Foundation (OSAF)
> bear at osafoundation.org
> http://www.osafoundation.org
>
> bear at code-bear.com
> http://code-bear.com
>
> PGP Fingerprint = 9996 719F 973D B11B E111  D770 9331 E822 40B3 CD29
>
>------------------------------------------------------------------------
>
>_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
>Open Source Applications Foundation "Dev" mailing list
>http://lists.osafoundation.org/mailman/listinfo/dev
>  
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osafoundation.org/pipermail/dev/attachments/20051020/790d49c2/attachment.html