[Dev] how to use the "review-request" system in bugzilla

[Ted Leung]

There's one additional benefit, which is to make patches public so that 
people who need them can get to them.

Ted

On Mar 17, 2005, at 2:59 PM, Alec Flett wrote:

>  Some of you may have noticed the "review request" system in bugzilla, 
> and a few of us have been using it for 0.5 stuff. This is a really 
> simple way for you to automatically request, and perform, bug reviews 
> for patches attached to a bug... yes, even easier than firing off an 
> email "can you review bug xxx?"
>
>  I'd like to suggest people try it out for at least a few days for any 
> patches they have, and see if you like the system.
>  Here's what I like:
>  1) review-requests look different from other bugmail - makes it clear 
> when I need to review the bug if I get behind in my bugmail
>  2) provides a paper-trail for who reviewed patches, and the comments 
> they made
>  3) ability to look at a page of outstanding requests for reviews - 
> both for me and by me
>
> To request a review:
>  1) Make a patch and attach it to the bug with an appropriate 
> description
>  2) Back in the bug, click "Edit" for that attachment
>  3) Where it says "review", select "?" in the little combo box. The 
> "Requestee" field should enable - just type in the e-mail address of 
> the person you want to review the bug. Think of "?" as meaning "can 
> you review this?"
>  4) Add any additional comments to the Comment field (i.e. "Do you 
> mind taking a look? The patch is small, I swear") - the comment will 
> go out in the e-mail to that person
>  5) click "Submit"
>
>  its that simple - an e-mail message will go out to your reviewer with 
> a link to the patch
>
> To respond to a request:
>  1) click the link to the patch
>  2a) if the patch looks good to you, change the "?" to a "+" - it 
> means "yes, I reviewed this"
>  2b) if the patch looks like the wrong fix, or you have comments and 
> want to see a new patch, change it to "-" - this means "I don't 
> approve this change" - essentially denying the review.
>  3) make any appropriate comments related to the patch in the comments 
> field. I often say "r=alecf" just so its clear.
>  4) click "Submit"
>
>  This time an e-mail message will go back to the requestor with the 
> subject saying "review approved" or "review denied"
>
> To see your review requests:
>  Click the "My Requests" link at the bottom of every bugzilla page. 
> You'll see a list of all the patches that you need to review, as well 
> as patches that you may have asked of others.
>  You can also filter this query further, and bookmark the query. I 
> keep seperate bookmarks for "reviews that I've requested" and "reviews 
> that I need to perform"
>
>  Hope this helps!
>
>  Alec
>  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "Dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/dev
>
----
Ted Leung                 Open Source Applications Foundation (OSAF)
PGP Fingerprint: 1003 7870 251F FA71 A59A  CEE3 BEBA 2B87 F5FC 4B42