[Dev] reviews on the trunk?

Philippe Bossut pbossut at osafoundation.org
Fri Dec 2 22:12:54 PST 2005


Jeffrey Harris wrote:

>Hi Folks,
>
>I just committed a few minor bug fixes to the trunk without getting a
>review for them.  Are we in that phase of development on the trunk
>again, now that 0.6 has branched?  I assumed so, but I wanted to double
>check on the list.
>
If Heikki didn't scream, then it's fine... :)
Seriously, mandatory code review are enforced only in the end game. That 
being said, don't be shy about askign for a code review for stuff that 
is beyond minor bug fixes and where you could use a second pair of eyes. 
Post commit reviews are also OK. Also, since we get the commit messages, 
we should all feel empowered to do review when commits are done.

Cheers,
- Philippe


More information about the Dev mailing list