[Dev] Re: [Commits] (bkirsch) removed refcount check fixes bug #2201

[Andi Vajda]

I believe Brian commented them out because the code was broken. Whoever made 
the assert change didn't test their change before checking it in, apparently.

The prudent way to go about this is to leave a comment in the code saying that 
this is where pinning would be necessary if the refcounted mode had to be 
turned off for some unforeseen reason. Like I said, this feature is still 
experimental and removing all traces of setPinned() calls right now is little 
rash. Having the comment be an assert is fine too.

Andi..


On Thu, 28 Oct 2004, John Anderson wrote:

> Hi Brian:
>
> I think commenting out this assert might be a mistake. I took out the 
> SetPinned calls, which requires we run the repository in auto pinning mode, 
> and added the assert to make sure we aren't running the wrong mode. Perhaps 
> my understanding of the isRefCounted call is incorrect (Andi correct me if 
> so), but we should probably make sure we're not running in the old mode or 
> the code won't work.
>
> John
>
>
> commits at osafoundation.org wrote:
>
>> Commit by: bkirsch
>> Modified files:
>> chandler/parcels/osaf/mail/smtp.py 1.18 1.19
>> chandler/parcels/osaf/mail/imap.py 1.30 1.31
>> 
>> Log message:
>> removed refcount check fixes bug #2201
>> 
>> ViewCVS links:
>> http://cvs.osafoundation.org/index.cgi/chandler/parcels/osaf/mail/smtp.py.diff?r1=text&tr1=1.18&r2=text&tr2=1.19
>> http://cvs.osafoundation.org/index.cgi/chandler/parcels/osaf/mail/imap.py.diff?r1=text&tr1=1.30&r2=text&tr2=1.31
>> 
>> Index: chandler/parcels/osaf/mail/smtp.py
>> diff -u chandler/parcels/osaf/mail/smtp.py:1.18 
>> chandler/parcels/osaf/mail/smtp.py:1.19
>> --- chandler/parcels/osaf/mail/smtp.py:1.18	Mon Oct 25 16:59:40 2004
>> +++ chandler/parcels/osaf/mail/smtp.py	Thu Oct 28 15:02:00 2004
>> @@ -1,5 +1,5 @@
>> -__revision__  = "$Revision: 1.18 $"
>> -__date__      = "$Date: 2004/10/25 23:59:40 $"
>> +__revision__  = "$Revision: 1.19 $"
>> +__date__      = "$Date: 2004/10/28 22:02:00 $"
>> __copyright__ = "Copyright (c) 2004 Open Source Applications Foundation"
>> __license__   = "http://osafoundation.org/Chandler_0.1_license_terms.htm"
>> 
>> @@ -455,7 +455,6 @@
>>         @return: C{None}
>>         """
>> 
>> -        assert self.itsView.isRefCounted(), "not refcounting doesn't make 
>> sense"
>>         self.account = None
>>         self.mailMessage = None
>> 
>> @@ -492,8 +491,6 @@
>>         if self.mailMessage is None:
>>             raise SMTPException("No MailMessage for UUID: %s" % 
>> self.mailMessageUUID)
>> 
>> -        assert self.itsView.isRefCounted(), "not refcounting doesn't make 
>> sense"
>> -
>> def getSMTPAccount(UUID=None):
>>     """
>>     This method returns a tuple containing:
>> 
>> Index: chandler/parcels/osaf/mail/imap.py
>> diff -u chandler/parcels/osaf/mail/imap.py:1.30 
>> chandler/parcels/osaf/mail/imap.py:1.31
>> --- chandler/parcels/osaf/mail/imap.py:1.30	Mon Oct 25 16:59:40 2004
>> +++ chandler/parcels/osaf/mail/imap.py	Thu Oct 28 15:02:00 2004
>> @@ -1,5 +1,5 @@
>> -__revision__  = "$Revision: 1.30 $"
>> -__date__      = "$Date: 2004/10/25 23:59:40 $"
>> +__revision__  = "$Revision: 1.31 $"
>> +__date__      = "$Date: 2004/10/28 22:02:00 $"
>> __copyright__ = "Copyright (c) 2004 Open Source Applications Foundation"
>> __license__   = "http://osafoundation.org/Chandler_0.1_license_terms.htm"
>> 
>> @@ -514,7 +514,6 @@
>>         NotifyUIAsync(self.downloadedStr, self.__printInfo)
>>         self.downloadedStr = None
>> 
>> -        # assert self.itsView.isRefCounted(), "not refcounting doesn't 
>> make sense"
>>         self.account = None
>> 
>>     def _expunge(self, result):
>> @@ -545,7 +544,6 @@
>>     def __getAccount(self):
>> 
>>         self.account = getIMAPAccount(self.accountUUID)
>> -        # assert self.itsView.isRefCounted(), "not refcounting doesn't 
>> make sense"
>> 
>>     def __printInfo(self, info):
>> 
>> 
>> _______________________________________________
>> Commits mailing list
>> Commits at osafoundation.org
>> http://lists.osafoundation.org/mailman/listinfo/commits
>> 
>