[Dev] Re: refcounted

Andi Vajda vajda at osafoundation.org
Thu Oct 28 13:43:03 PDT 2004


Regardless of the defaults chosen and implemented, this is a great idea,
there are a number of configuration flags to pass to open() or 
create() that would be best centralized and for which there may not be one 
'correct' set-fits-all.

Now, where is this util class going to go ?

Currently, the repository code, being almost at the bottom of the code stack 
is trying to not depend on higher level code layers. This, of course, is not 
always followed in the repository unit tests, maybe some of the repository 
unit tests should move out of the repository source tree altogether ?

Andi..

On Thu, 28 Oct 2004, Morgen Sagen wrote:

> So John, it seems like the best way to proceed is to move towards 
> modularizing Application.py (see application/Util.py) in such a way that 
> there is one and only one place that the repository gets initialized, and any 
> script (Chandler, all unit tests, document generator, etc.) can make use of 
> that.
>
> ~morgen
>
> On Oct 28, 2004, at 1:20 PM, Andi Vajda wrote:
>
>> 
>> Like we've discussed several times before, I have no immediate plans to 
>> default to refcounted.
>> The unit tests don't need pinning since only one view is involved in most 
>> of them. RepositoryTestCase.py, lines 44 and 47 is where you could also 
>> turn on refcounted by default.
>> Removing all the pinning code is at your option as well.
>> 
>> Andi..
>> 
>> On Thu, 28 Oct 2004, John Anderson wrote:
>> 
>>> Hi Andi:
>>> 
>>> Let me know if you plan to default to refcounted -- if so I'll be able to 
>>> remove the remaining SetPinnned code in Chandler without breaking the unit 
>>> tests.
>>> 
>>> John
>>> 
>>> Ted Leung wrote:
>>> 
>>>> +1
>>>> On Oct 25, 2004, at 1:35 PM, Morgen Sagen wrote:
>>>>> I also agree that we should just have the repository default to the new 
>>>>> refcounted mode.
>>>>> On Oct 25, 2004, at 6:59 AM, Lisa Dusseault wrote:
>>>>>> I'm tending to agree with John here.  What's the cost to keeping the 
>>>>>> refcounted and non-refcounted modes?  Are we going to test both modes? 
>>>>>> apply fixes to both modes?  document, etc?  Unused code goes stale 
>>>>>> quickly.
>>>>>> Lisa
>>>>>> On Oct 24, 2004, at 6:36 PM, John Anderson wrote:
>>>>>>> I already did that -- that wasn't my point. I was suggesting removing 
>>>>>>> the refcounted kwd since I can't think of any reason you'd want to use 
>>>>>>> the repository non ref counted -- and if you can think of a reason, 
>>>>>>> the kwd should be nonrefcounded so no kwd is ref counted (i.e. a 
>>>>>>> sensable default)
>>>>>>> Andi Vajda wrote:
>>>>>>>> You're welcome to turn it on in application/Application.py, line 207.
>>>>>>>> Same applies to the -exclusive option, line 206, the app needs to 
>>>>>>>> decide what it wants to do there as well.
>>>>>>>> Andi..
>>>>>>>> On Sun, 24 Oct 2004, John Anderson wrote:
>>>>>>>>> Andi:
>>>>>>>>> Now that we have the refcounted option in the repository, I'd vote 
>>>>>>>>> for making it the default and eliminating the option of 
>>>>>>>>> non-refcounting altogether -- unless you can think of any advantage 
>>>>>>>>> of non-refcounting.
>>>>>>>>> John
>>>>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>>>> Open Source Applications Foundation "Dev" mailing list
>>>>>>> http://lists.osafoundation.org/mailman/listinfo/dev
>>>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>>> Open Source Applications Foundation "Dev" mailing list
>>>>>> http://lists.osafoundation.org/mailman/listinfo/dev
>>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>>> Open Source Applications Foundation "Dev" mailing list
>>>>> http://lists.osafoundation.org/mailman/listinfo/dev
>>>> ----
>>>> Ted Leung                 Open Source Applications Foundation (OSAF)
>>>> PGP Fingerprint: 1003 7870 251F FA71 A59A  CEE3 BEBA 2B87 F5FC 4B42
>>>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>>> Open Source Applications Foundation "Dev" mailing list
>>>> http://lists.osafoundation.org/mailman/listinfo/dev
>>> 
>>> 
>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>> 
>> Open Source Applications Foundation "Dev" mailing list
>> http://lists.osafoundation.org/mailman/listinfo/dev
>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "Dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/dev
>


More information about the Dev mailing list