[Dev] Factory method for EmailAddress

[Donn Denman]

A few comments below:


On Aug 27, 2004, at 3:50 PM, Ducky Sherwood wrote:

>
>> The "me" EmailAddress
>> --------------------------------
>> Mimi's UI specifies a special display for the current user: "me".  
>> I'm thinking that I won't make any special "me" EmailAddress, I'll 
>> just make the __str__() method return "me" when the emailAddress 
>> matches the current default account.  I'll probably cache that 
>> account address in globals or a class variable for quick and easy 
>> access.
>
>
> Hmmm.  I would think that I'd want a test which returns true if it 
> matchs *any* of my email accounts, not just my current default.
>
For 0.4 we only have one account, so the problem won't come up until 
later.  We should check with Mimi to see what she wants - we may show 
"me <address>" so the user can tell which account was used.

On Aug 27, 2004, at 3:58 PM, Morgen Sagen wrote:

> Agreed.  What I was trying to say in response to the statement 
> "looking up existing items could impact performance of reading mail" 
> is that there shouldn't be any performance hit when reading mail.  But 
> perhaps when Donn says "reading mail" he means "downloading mail via 
> IMAP" and not "rendering mail messages in the UI" as I am assuming.  
> In which case I am mistaken and yes there could be a slight 
> performance hit doing EmailAddress lookups when downloading messages; 
> however you probably  gain back that extra time by committing fewer 
> EmailAddress items to the repository.
Yes, I should have said "downloading mail".  I'll code it up with Ted's 
new queries, and a disable switch, and see what the impact is on 
download speed.

>
> Anyway, +1 to EmailAddress factory.
>
> On Aug 27, 2004, at 3:39 PM, Brian Kirsch wrote:
>
>> The check should take place anywhere an EmailAddress is created 
>> including IMAP downloads, Contacts, SMTP sending, and IMAP Account 
>> configuration (replyToAddress).
>>
>> Brian Kirsch - Email Framework Engineer
>> Open Source Applications Foundation
>> 543 Howard St. 5th Floor 
>> San Francisco, CA 94105 
>> (415) 946-3056 
>>
>> On Aug 27, 2004, at 3:03 PM, Morgen Sagen wrote:
>>
>>>
>>> On Aug 27, 2004, at 2:41 PM, Donn Denman wrote:
>>>
>>>> Dev Folks,
>>>>
>>>> I'm planning to add a factory method for creation/reusing 
>>>> EmailAddress Items, and there are some architecture issues for 
>>>> consideration.
>>>>
>>>> Currently we're creating a lot of EmailAddress Items on the fly now 
>>>> that Email and Sharing are starting to work.  I'm thinking the 
>>>> factory method will allow us to reuse existing EmailAddress items 
>>>> to prevent build-up of duplicates.
>>>>
>>>> Architecture Issues:
>>>> ------------------------------
>>>> * Looking up existing items could impact performance of reading 
>>>> mail, but I'll use Ted's latest queries, and we can add a parameter 
>>>> to disable the lookup if it's not fast enough.
>>>
>>> Won't this lookup-for-existing-addresses happen as each email 
>>> message is downloaded by the imap layer (i.e., in the background)?  
>>> That way, when it comes time for the UI to display an email message, 
>>> you'll already have references to the appropriate EmailAddress 
>>> items?
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "Dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/dev