[Cosmo-dev] Caldav4j patch

Bobby Rullo br at osafoundation.org
Thu Sep 6 14:04:42 PDT 2007


Roberto,

I committed you patch with some minor modifications - We don't want  
to put the object in the cache with a null eTag, since eTags are what  
is used to determine if the object is stale or not.

Thanks again!

bobby

On Aug 29, 2007, at 9:09 AM, Roberto Polli wrote:

> Alle mercoledì 29 agosto 2007, Brian Moseley ha scritto:
>> sure thing. patches are always welcome.
> forewords:
> 1) fixed typo:
> 	- udpateMasterEvent
> 	+updateMasterEvent
>
> 2) bedework don't replies always with ETag, so we should check
> getResponseHeader("ETag") != null
>
> -        String newEtag = putMethod.getResponseHeader 
> ("ETag").getValue();
> +        Header h = putMethod.getResponseHeader("ETag");
> +        String newEtag = null;
> +        if (h != null) {
> +               newEtag = h.getValue();
> +        }
> +



More information about the cosmo-dev mailing list