[cosmo-dev] Re: [commits-cosmo] (mde) [6327] Major work for bug 11541 -- getting UI to work without any

[Matthew Eernisse]

Travis,

Thanks for having a look.

Response below ...

Travis Vachon wrote:
> Hi Matthew,
> 
> Reviewing this commit I had a tough time filtering the actual logic 
> changes from currentCollection -> selectedCollection name tweak. This is 
> exactly the kind of thing I was talking about in this thread:
> 
> http://lists.osafoundation.org/pipermail/cosmo-dev/2007-October/004892.html
> 
> It would be enormously useful in the future if you could package these 
> into two separate commits whenever possible. To be honest, the name 
> tweak seems entirely unnecessary, and it would be nice to be able to 
> revert just this if the commit ends up introducing bugs.

I realize there was a lot in there to digest at once, but the change 
you're referring to is not a simple name tweak.

The change was from a direct access of a public property 
(cosmo.app.pim.currentCollection, 
cosmo.app.pim.currentCollection.someMethod()) to method calls 
(cosmo.app.pim.getSelectedCollection(), getSelectedCollectionId(), 
getSelectedCollectionWriteable(), etc.) which return usable results in 
cases where there is no selected collection.

I opted to make the names of the new method calls consistent with the 
names of the method calls in cosmo.view.canvasBase (getSelectedItem(), 
getSelectedItemId(), etc.) that deal with the selected CalItem/ListItem 
for a particular selected-collection/view combo.

There's still some work to be done for this bug -- for example, there 
are still a bunch of places in the app where code is calling methods 
directly on getSelectedCollection() (e.g., 
cosmo.app.pim.getSelectedCollection().getUid()) rather than using the 
new method calls. I'll be continuing to clean stuff up. My first 
priority was dealing with the places in the code that were breaking the 
UI, and getting things into a usable state.

Thanks, and apologies for the confusion.


Matthew