[cosmo-dev] Re: [commits-cosmo] (mde) [6327] Major work for bug 11541 -- getting UI to work without any

[Travis Vachon]

Hi Matthew,

Reviewing this commit I had a tough time filtering the actual logic  
changes from currentCollection -> selectedCollection name tweak. This  
is exactly the kind of thing I was talking about in this thread:

http://lists.osafoundation.org/pipermail/cosmo-dev/2007-October/004892.html

It would be enormously useful in the future if you could package these  
into two separate commits whenever possible. To be honest, the name  
tweak seems entirely unnecessary, and it would be nice to be able to  
revert just this if the commit ends up introducing bugs.

One more nit below:

> Modified: cosmo/trunk/cosmo/src/main/webapp/js/cosmo/service/ 
> conduits/common.js (6326 => 6327)
>
> --- cosmo/trunk/cosmo/src/main/webapp/js/cosmo/service/conduits/ 
> common.js	2007-12-05 21:51:17 UTC (rev 6326)
> +++ cosmo/trunk/cosmo/src/main/webapp/js/cosmo/service/conduits/ 
> common.js	2007-12-05 23:14:45 UTC (rev 6327)
> @@ -138,7 +138,7 @@
>                     && !!item.getEventStamp().getRrule()){
>              transportFunc = "expandRecurringItem";
>          } else {
> -            throw new Error("Can not get dashboard items for " +  
> item);
> +            throw new Error("Cannot get dashboard items for " +  
> item);
>          }
>
>          var deferred = this._transport[transportFunc](item,  
> {projection: "/dashboard/eim-json"}, kwArgs);

Why didn't you move this to PimMessageResources? If you're going to  
take the time to change it, please take the time (under a minute in  
this case) to change it correctly!


Thank you!

-Travis

>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osafoundation.org/pipermail/cosmo-dev/attachments/20071205/f425f4d9/attachment.htm