[Cosmo-dev] bug 5078: read put request content into a tmp file
and compare the]
Brian Moseley
bcm at osafoundation.org
Tue Oct 17 09:58:56 PDT 2006
On 10/17/06, Jared Rhine <jared at wordzoo.com> wrote:
> As I read this, this change (use of a temp file to check content-length on
> PUT) has a significant impact on Cosmo's operational profile, particularly
> disk I/O. It'd be nice to stick with an application which is CPU-bound. I
> dunno if there's a conclusion here, but damn, really, a temp file? Ick.
> Seems like a code smell[1] to me. Is there no other reasonable way?
this is not a change from 0.4 - it's the reintroduction of
functionality that was in the original jcr implementation of cosmo
since day one.
if you can think of another way for us to verify that we really did
read the number of bytes specified in the content length-header that
doesn't require us to read the request content into memory and pass
that around between layers, i'm all ears :)
More information about the cosmo-dev
mailing list