[Cosmo-dev] Re: [commits-sandbox] [sandbox] (travis) [1123] GET /cmp/users paging and sorting now operational.

[Brian Moseley]

On 10/11/06, svncheckin at osafoundation.org <svncheckin at osafoundation.org> wrote:
>
> +
> + public static final String NAME_URL_STRING = "name";
> + public static final String USERNAME_URL_STRING = "username";
> + public static final String ADMIN_URL_STRING = "admin";
> + public static final String EMAIL_URL_STRING = "email";
> + public static final String CREATED_URL_STRING = "created";
> + public static final String LAST_MODIFIED_URL_STRING = "modified";
> +
> + public static final String USER_LIST_PATH = "/cmp/users";
> +
>  }

does any class other than UserResource use these constants? if not, i
think they should moved into that class.

>  String[] content = URLDecoder.decode(reader.readLine(),
> "UTF-8").split("&");
> - Set<String> inputStrings = new HashSet<String>(content.length, 1);
> + Set<String> userNames = new HashSet<String>(content.length, 1);

no need to parse the posted content manually. it's all available as
parameters of the ServletRequest.

>  /*
> + * Turn a paging query string into a PageCriteria object.
> + */
> + private PageCriteria parsePagingQueryString(String queryString)
> + throws QueryStringParseException {

same.