[Commits] (davids) colheader - updated some comments

commits at osafoundation.org commits at osafoundation.org
Tue Mar 22 13:18:32 PST 2005


Commit by: davids
Modified files:
internal/wxPython-2.5/src/generic/colheader.cpp 1.27 1.28

Log message:

colheader - updated some comments
r=TBD



ViewCVS links:
http://cvs.osafoundation.org/index.cgi/internal/wxPython-2.5/src/generic/colheader.cpp.diff?r1=text&tr1=1.27&r2=text&tr2=1.28

Index: internal/wxPython-2.5/src/generic/colheader.cpp
diff -u internal/wxPython-2.5/src/generic/colheader.cpp:1.27 internal/wxPython-2.5/src/generic/colheader.cpp:1.28
--- internal/wxPython-2.5/src/generic/colheader.cpp:1.27	Tue Mar 22 12:00:38 2005
+++ internal/wxPython-2.5/src/generic/colheader.cpp	Tue Mar 22 13:18:31 2005
@@ -1065,6 +1065,7 @@
 #else
 wxClientDC	dc( this );
 
+	// NB: this case being used for both Mac and GTK
 	for (long i=0; i<m_ItemCount; i++)
 		if (GetItemBounds( i, &boundsR ))
 			resultV |= m_ItemList[i]->DrawItem( this, &dc, &boundsR );
@@ -1230,11 +1231,11 @@
 
 	// add bitmap reference as needed
 	// NB: text and icon are mutually exclusive:
-	// - need m_BitmapJustification  + mgmt. to fully implement nonMutEx behavior
-	// FIXME: scaling a la wxBytmap::SetWidth/Height doesn't apply !!!
-	// FIXME: protect against HBMP leaks?
+	// - need m_BitmapJustification + mgmt. to fully implement non-MutEx behavior
 	if (itemRef->HasValidBitmapRef( itemRef->m_BitmapRef ))
 	{
+		// FIXME: scaling a la wxBitmap::SetWidth/Height doesn't apply !!!
+		// FIXME: protect against HBMP leaks?
 		itemData.fmt &= ~HDF_STRING;
 		itemData.fmt |= HDF_BITMAP;
 		itemData.mask |= HDI_BITMAP;
@@ -1246,7 +1247,7 @@
 	}
 
 	// add sort arrows as needed
-	// NB: should sort and bitmap be MutEx?
+	// NB: should sort arrows and bitmaps be MutEx?
 	itemData.fmt &= ~(HDF_SORTDOWN | HDF_SORTUP);
 	if (itemRef->m_BSelected && itemRef->m_BEnabled && itemRef->m_BSortEnabled)
 		itemData.fmt |= (itemRef->m_BSortAscending ? HDF_SORTUP : HDF_SORTDOWN);
@@ -1684,8 +1685,8 @@
 	DisposeRgn( savedClipRgn );
 
 	return (long)errStatus;
-#else
 
+#else
 wxRect				localBoundsR, subItemBoundsR;
 wxPoint				labelTextSize;
 long					originX, insetX;



More information about the Commits mailing list