[Commits] (davids) colheader - workaround for a wxWidgets-MSW clipping bug

commits at osafoundation.org commits at osafoundation.org
Tue Apr 19 16:02:12 PDT 2005


Commit by: davids
Modified files:
internal/wxPython-2.5/src/generic/colheader.cpp 1.74 1.75

Log message:

colheader - workaround for a wxWidgets-MSW clipping bug
r=TBD



ViewCVS links:
http://cvs.osafoundation.org/index.cgi/internal/wxPython-2.5/src/generic/colheader.cpp.diff?r1=text&tr1=1.74&r2=text&tr2=1.75

Index: internal/wxPython-2.5/src/generic/colheader.cpp
diff -u internal/wxPython-2.5/src/generic/colheader.cpp:1.74 internal/wxPython-2.5/src/generic/colheader.cpp:1.75
--- internal/wxPython-2.5/src/generic/colheader.cpp:1.74	Tue Apr 19 15:22:21 2005
+++ internal/wxPython-2.5/src/generic/colheader.cpp	Tue Apr 19 16:02:11 2005
@@ -1341,6 +1341,10 @@
 
 	resultV = 0;
 
+#if 0
+	wxLogDebug( _T("wxColumnHeader::Draw - entered") );
+#endif
+
 	if (m_BUseGenericRenderer)
 	{
 	wxPaintDC	dc( this );
@@ -1357,9 +1361,11 @@
 				resultV |= m_ItemList[i]->GenericDrawItem( this, &dc, &boundsR, m_BUseUnicode, m_BVisibleSelection );
 				if (m_BVisibleSelection && (i == m_ItemSelected))
 					wxColumnHeaderItem::GenericDrawSelection( &dc, &boundsR, &m_SelectionColour, m_SelectionDrawStyle );
-			}
 
-		dc.DestroyClippingRegion();
+				// NB: for MSW, existing clips must be destroyed before changing the clipping geometry;
+				// on Mac (and perhaps other platforms) this limitation doesn't apply
+				dc.DestroyClippingRegion();
+			}
 	}
 
 #if defined(__WXMSW__)



More information about the Commits mailing list