[chandler-dev] chandlerdb and pylucene-2.4.1-1

Andi Vajda vajda at osafoundation.org
Sat Apr 11 21:39:54 PDT 2009


On Apr 11, 2009, at 20:27, Jacob Floyd <techgurufloyd+osaf at gmail.com>  
wrote:

>> That part of the Lucene store extensions needs to be reworked.
>> The changes should be minimal, look at the svn history of PyLucene's
>> test_PythonDirectory.py.
>
> That seems to have been just the ticket I needed. Based on the  
> various changes visible in svn, I made a patch for chandlerdb/ 
> persistence/LuceneContainer.py which is attached (I hope that's ok  
> on this list, if not let me know, and I'll post it some other way)

That's definitely ok. This is what this list is for.

> It seems to work for me, all the tests apparently pass, but please  
> do a sanity check on what I changed.

Yes, these changes are the ones I'd expect. All looks familiar.

>> But, to do this properly, one needs to take on the task of upgrading
>> PyLucene in the chandler build.
>>
>> Given, at least, that no new functionality is introduced by this
>> upgrade that chandler lacks or desires, I don't think you'll get much
>> interest in it.
>
> ok. Well we'll see what happens with this patch then. Thanks for  
> looking it over.

If you run with this new build and don't get strange new bugs over  
time, I'd say your patch is good, but I didn't try it out myself.

Congrats !

Andi..

>
>
> Thank you,
> Jacob Floyd
> <LuceneContainer.py.diff>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "chandler-dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/chandler-dev


More information about the chandler-dev mailing list