[Chandler-dev] Re: [commits] (john) [13519] Eliminate unnecessary dependence on old script library when quitting after running recorded scripts.

[Heikki Toivonen]

commits at osafoundation.org wrote:
> Revision
>     13519 <http://viewcvs.osafoundation.org/chandler?view=rev&rev=13519>
> Author
>     john
> Date
>     2007-03-17 09:51:48 -0700 (Sat, 17 Mar 2007)
> 
> Also use ForceQuit to fix bug in feedback dialog after pressing restart
> where Chandler doesn't restart.
> 
> +    def ForceQuit(self):
> +        from osaf.framework.blocks.Block import Block
> +        try:
> +            Block.postEventByNameWithSender ("Quit", {})
> +        finally:
> +            sys.exit()
> +
> 
> -            try:
> -                from osaf.framework import scripting
> -                scripting.app_ns().root.Quit()
> -            except:
> -                sys.exit()
> +            wx.GetApp().ForceQuit()

I am puzzled by ForceQuit: postEventByNameWithSender just posts the Quit
event, and then we immediately sys.exit() before the Quit event has been
processed?

If the old code did not exit, how can the new code ensure exit?

In what situations, and on what platforms, have you observed feedback
dialog's restart failing? Are you sure it was because Chandler did not exit?

-- 
  Heikki Toivonen


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : http://lists.osafoundation.org/pipermail/chandler-dev/attachments/20070319/e5e425ae/signature.pgp