[Chandler-dev] Re: [commits] (vajda) [13406] - fixed bug 8296

[Heikki Toivonen]

commits at osafoundation.org wrote:
> Revision
>     13406 <http://viewcvs.osafoundation.org/chandler?view=rev&rev=13406>
> Author
>     vajda

>          try:
>              self.itsView.commit()
>              activity.completed()
>          except Exception, e:
>              logger.exception("Commit failed")
> +            self.setStatusMessage("Commit failed with %s" %(e))

I don't think this is right, the message can not be localized AFAIK. The
exception could be anything, and almost certainly will contain English
text. Besides, exception messages are generally meant for programmers,
not end users.

I suggest showing just "Commit failed, see log for details", and log the
actual exception.

-- 
  Heikki Toivonen


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 254 bytes
Desc: OpenPGP digital signature
Url : http://lists.osafoundation.org/pipermail/chandler-dev/attachments/20070307/66bd1c5f/signature.pgp