[Chandler-dev] CATS3

[Mikeal Rogers]

> I see in the patch that you moved the import wx to be inside the run 
> () call and while that does solve the python issue it seems that  
> there could still be a test created that doesn't.  This means that  
> all recorded tests would have to be checked to ensure that the  
> import list is "clean"

The recorder will always write tests this way. If someone writes a  
test by hand and screws this up then it won't be included in the test  
modules returned by get_test_modules.

>
> I still think that including this meta data in each individual test  
> makes it harder to discover what tests are being excluded - you now  
> would have to search all the test files to find this information  
> out instead of opening a single file in an editor and just looking.

I can write you a piece of code in rt.py that tells you all the  
excluded or available tests if you want.

>
> I think this boils down to having a meta data feature that saves  
> time for the test creator but that isn't the person who needs to  
> deal with that piece of meta data at all.  It's Dan and myself (or  
> others in QA/Build Release) who have to turn off tests on demand.   
> I just think that not having it in a central file location makes  
> that task harder.

If you're turning off a test, or you've fixed a test, you know which  
one it is and editing that file is trivial. Knowing which tests are  
being excluded and available is a bit harder but can be attained  
easily in code and I'm happy to write anything that will help you in  
this area

For me, this boils down to the question of where we should include  
information that tells the framework about how to run tests. This  
needs to be extensible so we can cover a variety of cases and extend  
the flexibility of the framework without rewriting it. Having one big  
file with all the framework semantics for the individual tests called  
out by the name of the file the module is from is _not_ extensible.  
This made sense for exclusions when we only called out tests by the  
script filename, and we are still doing this in rt.py, but the other  
ways we run collect and run tests think in terms of test modules, not  
test files.

If you want to special case the test exclusions because you're this  
opposed to it then fine, Dan and Bear are the ones primarily  
maintaining the running and excluding of the tests.

-Mikeal
-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://lists.osafoundation.org/pipermail/chandler-dev/attachments/20070607/9edcbb42/PGP.pgp