[Chandler-dev] Re: [commits] (john) [15115] fix bug#10157: Bug in NewEvent CPIA eventhandler r=bkirsch, vajda

[D John Anderson]

Hi Jeffrey:

This code doesn't come into play in the normal situation when the  
selected collection can be added to. Instead it comes up in the  
following two situations:

The original QuickEntry code had a situation where it added to the  
all collection, not the currently selected collection

When the selected collection is trash or it can't added to for some  
other reason, it adds to the all collection

In all these situations if the all collection isn't selected but  
items are added to it we select all and switch to the all collection  
so you can see the item you added. This is also the same way new item  
works today.

John

On Jul 26, 2007, at 12:03 PM, Jeffrey Harris wrote:


> Hi John,
>
>
>> +                if collection in sidebar.contents and collection  
>> is not selectedCollection:
>> +                    sidebar.postEventByName 
>> ("SelectItemsBroadcast", {'items':[collection]})
>>
>
> Changing the selected collection when adding an item with quick entry
> doesn't seem right to me.  This will change the user's context when
> adding items, but one of the core purposes of quick entry is to  
> quickly
> create an item without changing context.
>
> Perhaps this was intended to allow the item to be selected in the  
> table?
>  Unless we also change the filter after quick entry, in most cases  
> where
> the selected sidebar collection changes, we won't be able to select  
> the
> item in the table view, anyway.
>
> Sincerely,
> Jeffrey
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "chandler-dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/chandler-dev
>