[Chandler-dev] Re: [commits] (john) [15115] fix bug#10157: Bug in NewEvent CPIA event handler r=bkirsch, vajda

Jeffrey Harris jeffrey at osafoundation.org
Thu Jul 26 12:03:30 PDT 2007


Hi John,

> +                if collection in sidebar.contents and collection is not selectedCollection:
> +                    sidebar.postEventByName("SelectItemsBroadcast", {'items':[collection]})

Changing the selected collection when adding an item with quick entry
doesn't seem right to me.  This will change the user's context when
adding items, but one of the core purposes of quick entry is to quickly
create an item without changing context.

Perhaps this was intended to allow the item to be selected in the table?
 Unless we also change the filter after quick entry, in most cases where
the selected sidebar collection changes, we won't be able to select the
item in the table view, anyway.

Sincerely,
Jeffrey


More information about the chandler-dev mailing list