[Chandler-dev] Running functional tests with -O

[D John Anderson]

Wow!

I'm really glad Grant noticed this. Running tests without asserts is  
almost like not running tests at all. Perhaps we need a test that  
complains when we run non-performance tests with -O so we don't make  
this mistake again.

John

On Jul 2, 2007, at 9:44 PM, Mike Taylor wrote:

> rt.py was built trying to mimic exactly what do_tests.sh was  
> running - it could be that running with -O is something that snuck  
> in.  I'll have to check.
>
> It will be easy enough to remove if that is the consensus.
>
> On Jul 2, 2007, at 11:48 PM, Grant Baillie wrote:
>
>> Hmm ... I noticed that, in trunk (r14896), rt.py is running the  
>> functional tests (including the recorded scripts) with the python - 
>> O flag. Is that intentional?
>>
>> For one possibly unwanted effect of this, I noticed that the  
>> osaf.framework.script_recording.script_lib module does  
>> verification using assert statements, so no verification is now  
>> being done (i.e. you shouldn't believe the calls in the script to  
>> script_lib.VerifyOn()).
>>
>> Similarly, I'd think that asserts triggered in non-test code would  
>> cause test failures. (Skipping the asserts for perf tests is fine,  
>> of course).
>>
>> --Grant
>>
>> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>>
>> Open Source Applications Foundation "chandler-dev" mailing list
>> http://lists.osafoundation.org/mailman/listinfo/chandler-dev
>>
>>
> ---
> Bear
>
> Build and Release Engineer
> Open Source Applications Foundation (OSAF)
> bear at osafoundation.org
> http://www.osafoundation.org
>
> bear at code-bear.com
> http://code-bear.com
>
> PGP Fingerprint = 9996 719F 973D B11B E111  D770 9331 E822 40B3 CD29
>
>
> _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
>
> Open Source Applications Foundation "chandler-dev" mailing list
> http://lists.osafoundation.org/mailman/listinfo/chandler-dev