[Chandler-dev] Re: [commits] (heikki) [13779] Use more wx builtin IDs.

D John Anderson john at osafoundation.org
Tue Apr 3 14:43:39 PDT 2007


On Apr 3, 2007, at 2:28 PM, Heikki Toivonen wrote:


> I decided to leave them commented out so that it would be easier to  
> know
> what they actually are.

I think it's better to add a comment explaining this fact otherwise  
other readers of the code will be confused or think it was a mistake

>
>> It also has the unfortunate side-effect of removing the  
>> accelerators on mac.
>
> Sigh. <insert wx curses>
>
> On Linux, if you have the accelerators specified, it will disable some
> of the icons.
>
> Ok, I'll uncomment the accelerators. Shortcuts are more important than
> icons.

Alternatively you could conditionally exclude them for Linux, e.g. if  
not '__WXGTK__' in wx.PlatformInfo: accel = _(u'Ctrl+S')



More information about the chandler-dev mailing list