[Chandler-dev] Re: [commits] (bkirsch) [12261] First round of changes for mail offline mode.

[Reid Ellis]

To be fair, the code says:

#TMP VARIABLE TILL CHANDLER LEVEL OFFLINE FUNCTIONALITY IN PLACE
OFFLINE = False

So it's not something you want to be visible in the UI or user- 
settable. It will also be going away as soon as the functionality is  
there, so we shouldn't be spending too much time on it.

Given that, is this the right place to put these sorts of things?  
Seems similar to a C #define for #ifdef'ed conditional code.

Reid

On Nov 7, 2006, at 13:00, Heikki Toivonen wrote:
>> +        if constants.OFFLINE:
>
> This seems wrong. All things in constants.py should be, well, constant
> and this looks like a variable to me.
>
> I think we need the offline command line option so you could then  
> check
> for Globals.options.offline (and you could also get/set it from  
> menus etc.).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.osafoundation.org/pipermail/chandler-dev/attachments/20061107/215f9231/attachment.html