[Chandler-dev] Progress in i18n of Chandler
Markku Mielityinen
mmmm at osafoundation.org
Tue May 23 13:27:39 PDT 2006
Hi Brian,
> Very nice work.
>
> Here are the two issues I found:
> 1. File names of ics files contain ?. Some encoding issue happened
> there. We already talked about this on irc. So please remove these
> characters for now until we decide how we want to handle this.
It is a damn shame that svn does not have a proper unicode support. They
are probably aware of the fact but hopefully they also plan to do
something about it.
> 2. weeklyEvent.Check_DetailView({"displayName":u"%sWeekly call
> home%s", .... is missing the replacement variables.
> It should be weeklyEvent.Check_DetailView({"displayName":u"%sWeekly
> call home%s" % (i18n_char, i18n_char), ....
Silly me. These mods very very mechanical and I was typing really fast
so I knew to expect these. I hoped to track all these out when I ran the
test myself but obviously at least one got through.
> Your wx changes to add callback support to the wxGetTranslation
> mechanism look really good. I am not a wx / swig expert but as far as
> I can tell visually they look correct.
To me too but obviously only a test will make sure of this. The design
idea was mine - well probably we all had approximately the same idea as
it is very straightforward - but RobinD was a big help in its
implementation. He pointed me to existing code for examples and provided
many ideas to improve the implementation.
> I will need to test in a wx Chandler build environment. Unfortunately,
> at the moment on OS X I am unable to build the Chandler internal wx.
> Robin Dunn sent some suggestions but so far they have not worked. So
> until this get resolved I will focus on the functional test bug you
> found with UnicodeDecodeErrors.
OK. Hopefully the problem will not persist too long.
I have been working on the functional tests (to fix the testing
environment) as well but I think that with your better understanding of
python you will be more efficient regarding these problems (I can of
course learn). Hence basically, I am run out of planned work at the
moment. The implementations that you see were written mostly on Tue&Wed
last week. Since then I have been working on a couple of unplanned
things but these are not as useful towards our main goal of i18n of
Chandler. So any ideas what I should do next? Perhaps now is the time
for me to start learning about eggs and such...
> I have also removed my patch to initial the wxLocale in Chandler from
> the equation. I saved my changes locally and will revisit them later.
OK.
> First I would like to see the changes you made verified and committed
> then I will go back and work on loading the wx po libraries in Chandler.
OK.
> Make sense?
Yes I think so.
> So here is what I need from you.
>
> 1. Fix the two issues I detailed above.
Done.
> 2. Generate two diffs one containing the Chandler level changes
> (Functional Tests) and one containing the wx / swig changes.
See attached files.
>
> Doing number 2 allows me to patch the Chandler function test suite
> with out having to mess with the wx stuff yet.
Cheers,
Markku
More information about the chandler-dev
mailing list