[Dev] Coding guidelines follow-up: __revision__ etc.

Heikki Toivonen heikki at osafoundation.org
Thu Aug 5 10:48:51 PDT 2004


I am wondering why are these things variables in the first place, why 
not put this information in comments instead? Using variables eats a 
little bit of processing power and memory for something that could be 
avoided.

Then each of the __ variables:

__revision__. Pros: people can submit patches without CVS access and it 
will be clear which revision they are based on. Cons: your editor needs 
to automatically reload changed files, you cannot cleanly roll back a 
commit. What's the balance, can this be removed? Or would this need to 
wait until we switched to Subversion that could do offline diffs so that 
when we created a source tarball with .svn dirs others would have 
everything they needed.

__date__. Don't see much use for this, same cons as with __revision__. 
Should be removed.

__copyright__. Don't see much use for this. Should be just a comment.

__license__. Don't see much use for this. Should be just a comment.


-- 
   Heikki Toivonen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 249 bytes
Desc: OpenPGP digital signature
Url : http://lists.osafoundation.org/pipermail/chandler-dev/attachments/20040805/4a29c78a/signature.pgp


More information about the Dev mailing list